bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GL_LINK_WARNING


From: Eric Blake
Subject: Re: GL_LINK_WARNING
Date: Wed, 16 Dec 2009 18:34:08 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Bruno Haible on 12/16/2009 6:17 PM:
> In ANSI C, but not in C99, it is an error to typedef the same type twice:
>   typedef int _gl_warn_on_use;
>   typedef int _gl_warn_on_use;
> 
> Therefore the last line is better changed to 'extern int _gl_warn_on_use'.

OK, I'll make that change.

> 
> Actually one might consider to move the semicolon that terminates the
> declaration into the expansion of _GL_WARN_ON_USE. Then, in the unsupported
> case, the expansion of _GL_WARN_ON_USE(function, message) can be empty.

But then editors like emacs get confused.  Having an explicit semicolon at
the call site rather than embedded in the macro keeps indentation sane.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkspipAACgkQ84KuGfSFAYDcSgCeL1c5L9Hu7VSeZwZfyuAjXmNg
lOwAoJO5EFPMw860wioDzGZ3Y0BEwb88
=pztZ
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]