bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: inline cleanup, part 2


From: Jim Meyering
Subject: Re: inline cleanup, part 2
Date: Thu, 31 Dec 2009 16:04:33 +0100

Bruno Haible wrote:
> Eric Blake wrote:
>> But yes, it is sufficient to use the
>> lighter-weight AC_C_INLINE, rather than the full-blown 'inline' module.
>> Thanks for catching that.
>
> This overkill also occurs in a number of other places. I'm applying the first
> patch below.
>
> Jim, is the second patch (at the end) below also OK to apply?
...
> 2009-12-31  Bruno Haible  <address@hidden>
>
>       Use AC_C_INLINE instead of module 'inline' where possible.
>       * m4/openat.m4 (gl_PREREQ_OPENAT): Require AC_C_INLINE.
>       * modules/openat (Depends-on): Remove inline.
...
>  AC_DEFUN([gl_PREREQ_OPENAT],
>  [
> +  AC_REQUIRE([AC_C_INLINE])
>    AC_REQUIRE([gl_PROMOTED_TYPE_MODE_T])
>    :
>  ])
> --- modules/openat.orig       Thu Dec 31 15:48:03 2009
> +++ modules/openat    Thu Dec 31 15:30:51 2009
> @@ -23,7 +23,6 @@
>  fcntl-h
>  fdopendir
>  gettext-h
> -inline

That looks fine.  Thanks!

Eric, yes, please add your name to modules/openat's Maintainer: field.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]