[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
select, nanosleep, mbslen, at-func2
From: |
Ian Beckwith |
Subject: |
select, nanosleep, mbslen, at-func2 |
Date: |
Thu, 7 Jan 2010 01:05:29 +0000 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hi,
select (LGPLv2+) and nanosleep (GPL) both need a dependency on
sockets (LGPLv2+).
Reported against gnuit:
> From: "Nelson H. F. Beebe" <address@hidden>
> Several months ago, I successfully built gnuit-4.9.5 on 20+ flavors of
> Unix. Today, I tried a recent addition to our test laboratory: MirOS
> (http://www.mirbsd.org/), formerly known as MirBSD, and an offshoot of
> the OpenBSD development.
>
> Compilation failed in lib/mbslen.c because of a macro expansion of the
> name mbslen. I added protecting parentheses, and the build,
> validation, and installation then succeeded. The patch is trivial:
>
> % diff mbslen.c~ mbslen.c
> 29c29
> < mbslen (const char *string)
> ---
> > (mbslen) (const char *string)
It looks more like a workaround than a fix to me, hopefully you can
figure out the right thing to do.
Also, in the Debian BTS
(http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561117)
a report about the GNU/kFreeBSD port:
> From: Petr Salinger <address@hidden>
> Hi,
>
> during build of coreutils-8.1:
>
> at-func2.c: In function 'at_func2':
> at-func2.c:113: warning: attempt to free a non-heap object 'proc_buf1'
>
> IMO, the right fix is
>
> --- lib/at-func2.c
> +++ lib/at-func2.c
> @@ -110,7 +110,7 @@
> }
> }
> else if (proc_file1 != proc_buf1 && proc_file1 != file1)
> - free (proc_buf1);
> + free (proc_file1);
> }
> }
cheers,
Ian.
PS In general, would you prefer separate messages for each bug?
--
Ian Beckwith - address@hidden - http://erislabs.net/ianb/
GPG fingerprint: AF6C C0F1 1E74 424B BCD5 4814 40EC C154 A8BA C1EA
Listening to: Shins - Wincing the Night Away - Red Rabbits
signature.asc
Description: Digital signature
- select, nanosleep, mbslen, at-func2,
Ian Beckwith <=
- at-func2 (was: select, nanosleep, mbslen, at-func2), Eric Blake, 2010/01/06
- select (was: select, nanosleep, mbslen, at-func2), Eric Blake, 2010/01/06
- mbslen on MirBSD (was: select, nanosleep, mbslen, at-func2), Bruno Haible, 2010/01/07