bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: open MinGW failure


From: Bruno Haible
Subject: Re: open MinGW failure
Date: Sat, 9 Jan 2010 14:08:54 +0100
User-agent: KMail/1.9.9

Simon Josefsson wrote:
> diff --git a/m4/open.m4 b/m4/open.m4
> index d705b3a..bc04613 100644
> --- a/m4/open.m4
> +++ b/m4/open.m4
> @@ -8,7 +8,7 @@ AC_DEFUN([gl_FUNC_OPEN],
>  [
>    AC_REQUIRE([AC_CANONICAL_HOST])
>    case "$host_os" in
> -    mingw* | pw*)
> +    pw*)
>        gl_REPLACE_OPEN
>        ;;
>      *)
> @@ -40,6 +40,9 @@ changequote(,)dnl
>                 freebsd*)        gl_cv_func_open_slash="guessing no" ;;
>                 solaris2.[0-9]*) gl_cv_func_open_slash="guessing no" ;;
>                 hpux*)           gl_cv_func_open_slash="guessing no" ;;
> +            # The misbehaviour is only under Wine, see
> +            # http://bugs.winehq.org/show_bug.cgi?id=21292
> +            mingw*)          gl_cv_func_open_slash="guessing no" ;;
>                 *)               gl_cv_func_open_slash="guessing yes" ;;
>               esac
>  changequote([,])dnl

We have switched from tabs to spaces for indentation.

Removing the mingw* case in the 'case' statement is wrong, because the * case
executes an AC_CACHE_CHECK which would yield 'no' when cross-compiling to mingw
or natively compiling to mingw via wine but yield 'yes' when natively compiling
to mingw via Cygwin. In other words: The AC_CACHE_CHECK test would yield
different results depending on the compilation environment, therefore it
must be bypassed through a 'mingw*' case clause.

pw* should be treated like mingw*, because there's no difference regarding
target executable format. Both can be executed under Wine.

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]