bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: warn-on-use preview, v2


From: Eric Blake
Subject: Re: warn-on-use preview, v2
Date: Mon, 11 Jan 2010 17:45:30 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Eric Blake <ebb9 <at> byu.net> writes:

> Here's spin two of the patch.  It turns out that doing one shell loop per
> header also allows us to fold in platform-specific inclusion requirements.
> 
...
> Some of our unit tests never use large files, so rather than drag
> in a dependency on fseeko, they should be the first compilation
> units to use _GL_NO_LARGE_FILES. 

I found a couple more tests that warned, but which have no reason to warn.


From: Eric Blake <address@hidden>
Date: Mon, 11 Jan 2010 10:35:52 -0700
Subject: [PATCH] tests: avoid more large file warnings

* tests/test-fflush.c: Avoid warning about ftell use.
* tests/test-fseek.c: Avoid warning about fseek use.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog           |    6 ++++++
 tests/test-fflush.c |    3 +++
 tests/test-fseek.c  |    3 +++
 3 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index d075b31..a06814b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-01-11  Eric Blake  <address@hidden>
+
+       tests: avoid more large file warnings
+       * tests/test-fflush.c: Avoid warning about ftell use.
+       * tests/test-fseek.c: Avoid warning about fseek use.
+
 2010-01-11  Jim Meyering  <address@hidden>

        utimecmp: avoid new warning from upcoming gcc-4.5.0
diff --git a/tests/test-fflush.c b/tests/test-fflush.c
index 38bedd9..12403e2 100644
--- a/tests/test-fflush.c
+++ b/tests/test-fflush.c
@@ -18,6 +18,9 @@

 #include <config.h>

+/* None of the files accessed by this test are large, so disable the
+   ftell link warning if we are not using the gnulib ftell module.  */
+#define _GL_NO_LARGE_FILES
 #include <stdio.h>

 #include "signature.h"
diff --git a/tests/test-fseek.c b/tests/test-fseek.c
index 9b25e1d..46d5c8a 100644
--- a/tests/test-fseek.c
+++ b/tests/test-fseek.c
@@ -18,6 +18,9 @@

 #include <config.h>

+/* None of the files accessed by this test are large, so disable the
+   fseek link warning if the user requested GNULIB_POSIXCHECK.  */
+#define _GL_NO_LARGE_FILES
 #include <stdio.h>

 #include "signature.h"
-- 
1.6.4.2







reply via email to

[Prev in Thread] Current Thread [Next in Thread]