Re: GNU patch 2.6.1 fails to build on IRIX

[Eric Blake]

[adding bug-patch]

According to Stuart Shelton on 1/14/2010 9:47 AM:
> On IRIX (and, indeed, any platform without strnlen() or strndup()),

Hmm.  'gnulib-tool --with-tests --create-testdir --dir=dir xstrndup', then
configuring that directory on mingw, did not fail.  So I'm not reproducing
the failure.

Is GNU patch properly using the string.in.h replacement header?  Maybe the
problem is that not enough modules were imported.  So I guess my next step
is to download the patch sources and try and reproduce the failure that way.

> patch 2.6.1 fails with:
> 
> cc-1196 cc: WARNING File = gl/lib/strndup.c, Line = 33
>   The indicated function is declared implicitly.
> 
>     size_t len = strnlen (s, n);

Again, I don't see any reason why our replacement <string.h> would have
failed to declare this, if the strnlen module is properly in use.

> +++ ./gl/lib/strndup.c        2010-01-14 16:22:49.439646360 +0000
> @@ -23,7 +23,7 @@
>
>  #include <stdlib.h>
>
> -#ifndef HAVE_DECL_STRNLEN
> +#if HAVE_DECL_STRNLEN != 1
>  extern size_t strnlen (const char *, size_t);
>  #endif

Oh, now I see it.  The latest gnulib version of strndup.c does not look
like this.  Therefore, the bug is in patch, and merely that the last patch
release has an out-of-date copy of gnulib.

> patch 2.6.1 also runs into the infamous MIPSpro error:
> 
> cc-1999 cc: ERROR File = src/bestmatch.h, Line = 135
>   "jumping out of a block containing VLAs" is not currently implemented
> 
> 1 error detected in the compilation of "src/merge.c".

That should be reported to the address@hidden list.  Gnulib is not in
charge of that file.

-- 
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden

signature.asc
Description: OpenPGP digital signature