bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.


From: Ralf Wildenhues
Subject: Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.
Date: Sat, 16 Jan 2010 16:13:50 +0100
User-agent: Mutt/1.5.20 (2009-10-28)

Hello,

* Eric Blake wrote on Thu, Jan 14, 2010 at 02:31:17PM CET:
> According to Jim Meyering on 1/14/2010 1:08 AM:
> > Think of a set-up function that (when $EXEEXT is nonempty)
> > iterates through the *.$EXEEXT executables in a specified directory...
> > 
> > create_exe_shim_functions ()
> > {
> >   case $EXEEXT in
> >     '') return 0 ;;
> >     .exe) ;;
> >     *) echo "$0: unexpected value of $EXEEXT" 1>&2; return 1 ;;
> >   esac
> 
> So we still have to pass EXEEXT through TESTS_ENVIRONMENT in
> modules/*-tests for any test that uses a .sh file.

I've always wondered why gnulib doesn't simply do that by default for
all of its tests modules.  I mean, you could get fancy and write a
module that does nothing but passing EXEEXT through TESTS_ENVIRONMENT
and let all compiled tests depend on that, but what's the point?

(Sure, just looking for files matching *.exe is probably safe in
practice as well.)

Just my two cents.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]