bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] readtokens: do not leak internal token_lengths buffer


From: Jim Meyering
Subject: [PATCH] readtokens: do not leak internal token_lengths buffer
Date: Mon, 18 Jan 2010 08:11:36 +0100

FYI,

>From 06758294115f10dd93055a531113c24f8930f992 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Mon, 18 Jan 2010 08:10:07 +0100
Subject: [PATCH] readtokens: do not leak internal token_lengths buffer

* lib/readtokens.c (readtokens): Free the local, lengths,
when the supplied "token_lengths" parameter is NULL.
---
 ChangeLog        |    6 ++++++
 lib/readtokens.c |    2 ++
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 56b60d2..42257ee 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-01-18  Jim Meyering  <address@hidden>
+
+       readtokens: do not leak internal token_lengths buffer
+       * lib/readtokens.c (readtokens): Free the local, lengths,
+       when the supplied "token_lengths" parameter is NULL.
+
 2010-01-17  Ralf Wildenhues  <address@hidden>

        Fix a couple of missing LIBTHREAD link failures on AIX.
diff --git a/lib/readtokens.c b/lib/readtokens.c
index e29f20e..c65c1b1 100644
--- a/lib/readtokens.c
+++ b/lib/readtokens.c
@@ -197,5 +197,7 @@ readtokens (FILE *stream,
   *tokens_out = tokens;
   if (token_lengths != NULL)
     *token_lengths = lengths;
+  else
+    free (lengths);
   return n_tokens;
 }
--
1.6.6.638.g2bc54




reply via email to

[Prev in Thread] Current Thread [Next in Thread]