Re: [PATCH] xstrtoll: new module

[Jim Meyering]

Bruno Haible wrote:
> Hi Jim,
>
>> diff --git a/tests/test-xstrtoll.c b/tests/test-xstrtoll.c
>> index 47a552e..03dd232 100644
>> --- a/tests/test-xstrtoll.c
>> +++ b/tests/test-xstrtoll.c
>> @@ -1,4 +1,4 @@
>>  #define __xstrtol xstrtoll
>>  #define __strtol_t long long int
>> -#define __spec "lld"
>> +#define __spec PRId64
>>  #include "test-xstrtol.c"
>
> PRId64 is not correctly defined on all platforms (see
> doc/posix-headers/inttypes.texi), therefore a dependency towards module
> 'inttypes' is needed.

Good catch.

> Similarly, since tests/test-xstrtol.c includes <inttypes.h>, the same
> dependency is needed also in 'xstrtol-tests'.
>
> Additionally, the dependency from 'xstrtoll-tests' to 'xstrtoll' is redundant.
> This is now actually documented, since yesterday.

Both changes are fine.  Thanks.

Have you considered making gnulib-tool diagnose (I'd prefer failure)
such redundant dependencies?

> Here's a proposed patch:
>
>
> 2010-01-25  Bruno Haible  <address@hidden>
>
>       * modules/xstrtol-tests (Depends-on): Add inttypes.
>       * modules/xstrtoll-tests (Depends-on): Likewise. Remove xstrtoll.
>
> --- modules/xstrtol-tests.orig        Mon Jan 25 21:41:22 2010
> +++ modules/xstrtol-tests     Mon Jan 25 21:37:12 2010
> @@ -4,6 +4,7 @@
>  tests/test-xstrtol.sh
>
>  Depends-on:
> +inttypes
>
>  configure.ac:
>
> --- modules/xstrtoll-tests.orig       Mon Jan 25 21:41:22 2010
> +++ modules/xstrtoll-tests    Mon Jan 25 21:37:08 2010
> @@ -6,7 +6,7 @@
>  tests/test-xstrtoll.sh
>
>  Depends-on:
> -xstrtoll
> +inttypes
>
>  configure.ac:
>