bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] Avoid some of the sc_ rules to freeze


From: Jim Meyering
Subject: Re: [patch] Avoid some of the sc_ rules to freeze
Date: Mon, 22 Feb 2010 14:52:39 +0100

Pádraig Brady wrote:
...
> Would it be better to just add /dev/null as a parameter to grep?
> I.E. like:
>
>       @grep -nE 'error \(EXIT_SUCCESS,'                               \
>           $$($(VC_LIST_EXCEPT) /dev/null | grep -E '\.[chly]$$')&&    \
>         { echo '$(ME): found error (EXIT_SUCCESS' 1>&2; exit 1; } || :

Definitely.
Avoids that pesky duplication.
Jose, if you redo the patch, I'll apply it.
BTW, we prefer diffs in the git format-patch style,
so it's slightly easier to attribute.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]