Re: test-string-c++ test failure

[Jim Meyering]

Jim Meyering wrote:

> Bruno Haible wrote:
> ...
>> This should fix it:
>>
>> 2010-03-11  Bruno Haible  <address@hidden>
>>
>>      Fix problems with overloaded C++ definitions of memchr, strpbrk, etc.
>>      * build-aux/c++defs.h (_GL_CXXALIAS_SYS_CAST2): Make it work regardless
>>      whether the system provides one variant or multiple variants of the
>>      function.
>>      * lib/string.in.h (memchr, strpbrk): Use _GL_CXXALIAS_SYS_CAST2 for all
>>      C++ compilers.
>>      (memrchr, rawmemchr, strchrnul, strstr, strcasestr): Use
>>      _GL_CXXALIAS_SYS_CAST2 instead of _GL_CXXALIAS_SYS.
>>      Reported by Jim Meyering.
>
> Thanks!
> That does indeed solve the problem for me.

FYI, I updated coreutils to use the version of gnulib
I'd confirmed to work on F12, and pushed the result.
However, it appears not to be the complete solution,
since the nixos hydra autobuilder reports a coreutils
build failure on linux-686:

  http://hydra.nixos.org/build/324839



Oh.  Rats.
I see my mistake.
I figured the failure (after update) was due to a stale lib/string.h,
so removed that and reran "make", which succeeded.
However, I should have rerun "make check".  *that* still fails,
even on F12.

In file included from test-string-c++.cc:23:
../lib/string.h:299: error: type of 'memchr' is unknown
../lib/string.h:299: error: invalid type in declaration before ';' token
../lib/string.h:299: error: 'int memchr' redeclared as different kind of symbol
/usr/include/string.h:76: error: previous declaration of 'const void* 
memchr(const void*, int, size_t)'
In file included from test-string-c++.cc:23:
../lib/string.h:375: error: type of 'memrchr' is unknown
../lib/string.h:375: error: invalid type in declaration before ';' token
../lib/string.h:375: error: 'int memrchr' redeclared as different kind of symbol
/usr/include/string.h:116: error: previous declaration of 'const void* 
memrchr(const void*, int, size_t)'
In file included from test-string-c++.cc:23:
../lib/string.h:580: error: type of 'strpbrk' is unknown
../lib/string.h:580: error: invalid type in declaration before ';' token
../lib/string.h:580: error: 'int strpbrk' redeclared as different kind of symbol
/usr/include/string.h:294: error: previous declaration of 'const char* 
strpbrk(const char*, const char*)'
In file included from test-string-c++.cc:23:
../lib/string.h:675: error: type of 'strstr' is unknown
../lib/string.h:675: error: invalid type in declaration before ';' token
../lib/string.h:675: error: 'int strstr' redeclared as different kind of symbol
/usr/include/string.h:321: error: previous declaration of 'const char* 
strstr(const char*, const char*)'