Re: [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype

[Bruno Haible]

Hi Eric,

Rapid review:

> diff --git a/m4/forkpty.m4 b/m4/forkpty.m4
> index 38b51b7..f1da918 100644
> --- a/m4/forkpty.m4
> +++ b/m4/forkpty.m4
> @@ -23,9 +23,83 @@ AC_DEFUN([gl_PTY_LIB],
>  AC_DEFUN([gl_FORKPTY],
>  [
>    AC_REQUIRE([gl_PTY_LIB])
> +  AC_REQUIRE([gl_PTY])
> +
> +  AC_CHECK_DECLS([forkpty],,, [[
> +#if HAVE_UTIL_H
> +# include <util.h>
> +#endif
> +#if HAVE_LIBUTIL_H
> +# include <libutil.h>
> +#endif
> +]])

Why does this set of includes not contain
#if HAVE_PTY_H
# include <pty.h>
#endif
? Isn't it needed on glibc systems?

>  AC_DEFUN([gl_OPENPTY],
>  [
>    AC_REQUIRE([gl_PTY_LIB])
> +  AC_REQUIRE([gl_PTY])
> +
> +  AC_CHECK_DECLS([openpty],,, [[
> +#if HAVE_UTIL_H
> +# include <util.h>
> +#endif
> +#if HAVE_LIBUTIL_H
> +# include <libutil.h>
> +#endif
> +]])

Likewise.

Bruno