Re: [PATCH] maint: enforce one small aspect of formatting style: space-before-"("

[Eric Blake]

On 03/20/2010 05:24 AM, Jim Meyering wrote:
> +_space_before_paren_exempt =? \\n\\$$
> +_space_before_paren_exempt = \
> +  (\\n\\$$|%s\(to %s|delimit-method|(date|group|character)\(s\))
> +# Ensure that there is a space before each open parenthesis in C code.
> +sc_space_before_open_paren:
> +     @if $(VC_LIST_EXCEPT) | grep -l '\.[ch]$$' > /dev/null; then    \
> +       if (cpp -fpreprocessed < /dev/null > /dev/null 2>&1); then    \
> +         fail=0;                                                     \
> +         for c in $$($(VC_LIST_EXCEPT) | grep '\.[ch]$$'); do        \
> +           cpp -fpreprocessed $$c 2>/dev/null                        \
> +             | grep -ni '[[:alnum:]]('                               \
> +             | grep -vE '$(_space_before_paren_exempt)'              \
> +             | grep . && { fail=1; echo "*** $$c"; };                \
> +         done;                                                       \
> +         test $$fail = 1 &&                                          \
> +           { echo '$(ME): the above files lack a space-before-open-paren' \
> +               1>&2; exit 1; } || :;                                 \
> +       else                                                          \
> +         echo '$(ME): skipping test $@: cppi not installed' 1>&2;    \

Too much copy-n-paste?  The error message should really be talking about
'cpp -fpreprocessed'.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature