[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint: enforce one small aspect of formatting style: space-b
From: |
Bruno Haible |
Subject: |
Re: [PATCH] maint: enforce one small aspect of formatting style: space-before-"(" |
Date: |
Sat, 20 Mar 2010 14:56:17 +0100 |
User-agent: |
KMail/1.9.9 |
Hi Jim,
> Any objections?
I cannot reasonably object, because you have not precisely explained what the
"small aspect of formatting style" is. The subject line says: space-before-"(".
The comment says:
Ensure that there is a space before each open parenthesis in C code.
But there are currently 7542 occurrences of a non-space before an open
parenthesis in gnulib:
$ grep '[^ ](' `find lib -name '*.[hc]'` | wc -l
7542
So I assume the comment is not precisely describing the "small aspect of
formatting style".
What is the precise description of the small aspect?
Which lines in gnulib would be flagged by the change?
Bruno
Re: [PATCH] maint: enforce one small aspect of formatting style: space-before-"(", Jim Meyering, 2010/03/20