[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHv4] gethostname: fix build on mingw
From: |
Bruno Haible |
Subject: |
Re: [PATCHv4] gethostname: fix build on mingw |
Date: |
Mon, 22 Mar 2010 20:47:55 +0100 |
User-agent: |
KMail/1.9.9 |
Eric Blake wrote:
> +/* Get all possible declarations of gethostname(). */
> +#if @UNISTD_H_HAVE_WINSOCK2_H@ && !defined _GL_INCLUDING_WINSOCK2_H
> +# define _GL_INCLUDING_WINSOCK2_H
> +# include <winsock2.h>
> +# undef _GL_INCLUDING_WINSOCK2_H
> +#endif
>
Would it be possible to conditionalize this with
#if @GNULIB_GETHOSTNAME@
like it was before? In a package that has nothing to do with
sockets and nothing to do with gethostname(), I wouldn't want to
see all <winsock2.h> definitions in virtually all compilation units.
Bruno
- Re: [PATCH] gethostname: fix build on mingw, (continued)
- Re: [PATCH] gethostname: fix build on mingw, Matthias Bolte, 2010/03/21
- Re: [PATCH] gethostname: fix build on mingw, Eric Blake, 2010/03/22
- [PATCHv4] gethostname: fix build on mingw, Eric Blake, 2010/03/22
- Re: [PATCHv4] gethostname: fix build on mingw, Simon Josefsson, 2010/03/22
- Re: [PATCHv4] gethostname: fix build on mingw, Eric Blake, 2010/03/22
- Re: [PATCHv4] gethostname: fix build on mingw, Simon Josefsson, 2010/03/22
- Re: [PATCHv4] gethostname: fix build on mingw, Eric Blake, 2010/03/22
- Re: [PATCHv4] gethostname: fix build on mingw, Matthias Bolte, 2010/03/22
- Re: [PATCHv4] gethostname: fix build on mingw,
Bruno Haible <=
- [PATCH] gethostname: further tweaks, Eric Blake, 2010/03/22
- Re: [PATCH] gethostname: fix build on mingw, Matthias Bolte, 2010/03/21