[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: new syntax-check rule for @acronym?
From: |
Eric Blake |
Subject: |
Re: new syntax-check rule for @acronym? |
Date: |
Thu, 25 Mar 2010 17:19:19 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b1 Thunderbird/3.0.3 |
On 03/24/2010 01:46 AM, Simon Josefsson wrote:
>> syntax-check test for this seems useful, to foster harmonization across
>> GNU packages. How about the patch below?
>>
>> I have no objection, certainly.
>
> I pushed the patch below.
>
> +# Don't use Texinfo @acronym{} as it is not a good idea.
> +sc_texinfo_acronym:
> + @grep -nE '@acronym{' \
> + $$($(VC_LIST_EXCEPT) | grep -E '\.texi$$') && \
> + { echo '$(ME): found use of Texinfo @acronym{}' 1>&2; \
> + exit 1; } || :
This hangs for non-GNU projects, like libvirt, that have no .texi
documentation. We really need to make progress on the patch to refactor
maint.mk rules per Jose's ideas:
http://lists.gnu.org/archive/html/bug-gnulib/2010-02/msg00242.html
which would conveniently fix this rule in the process.
Meanwhile, I noticed that the last email in that thread asked Jose to
change an unportable use of test -a. Perhaps we should migrate
libvirt's recent syntax check to cfg.mk, since it seems to be a
pervasive problem?
https://www.redhat.com/archives/libvir-list/2010-March/msg01127.html
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature