bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] build: avoid link failure on systems using gnulib's fcntl bu


From: Bruno Haible
Subject: Re: [PATCH] build: avoid link failure on systems using gnulib's fcntl but not open
Date: Sun, 28 Mar 2010 01:49:15 +0100
User-agent: KMail/1.9.9

>       Resolve conflict between the two kinds of module indicators.
>       * m4/gnulib-common.m4 (gl_MODULE_INDICATOR_FOR_TESTS): Define
>       GNULIB_TEST_XYZ instead of GNULIB_XYZ.

After this change, some GNULIB_XYZ macros are unused. I'm applying the
patch below.

Simon, is it ok to remove the GNULIB_GC_CAMELLIA macro? I see it nowhere
used in gnulib. Is it used in one of your packages?
--- modules/crypto/gc-camellia.orig     Sun Mar 28 01:39:37 2010
+++ modules/crypto/gc-camellia  Sun Mar 28 01:39:21 2010
@@ -9,7 +9,6 @@
 
 configure.ac:
 gl_GC_CAMELLIA
-gl_MODULE_INDICATOR([gc-camellia])
 
 Makefile.am:
 


Committed:

2010-03-27  Bruno Haible  <address@hidden>

        Remove unused GNULIB_XYZ macro definitions.
        * modules/dup3 (configure.ac): Remove gl_MODULE_INDICATOR invocation.
        * modules/fseek (configure.ac): Likewise.
        * modules/ioctl (configure.ac): Likewise.
        * modules/open (configure.ac): Likewise.
        * modules/stdlib-safer (configure.ac): Likewise.

--- modules/dup3.orig   Sun Mar 28 01:39:37 2010
+++ modules/dup3        Sun Mar 28 01:39:21 2010
@@ -14,7 +14,6 @@
 
 configure.ac:
 gl_FUNC_DUP3
-gl_MODULE_INDICATOR([dup3])
 gl_UNISTD_MODULE_INDICATOR([dup3])
 
 Makefile.am:
--- modules/fseek.orig  Sun Mar 28 01:39:37 2010
+++ modules/fseek       Sun Mar 28 01:39:21 2010
@@ -11,7 +11,6 @@
 
 configure.ac:
 gl_FUNC_FSEEK
-gl_MODULE_INDICATOR([fseek])
 gl_STDIO_MODULE_INDICATOR([fseek])
 
 Makefile.am:
--- modules/ioctl.orig  Sun Mar 28 01:39:37 2010
+++ modules/ioctl       Sun Mar 28 01:39:21 2010
@@ -20,7 +20,6 @@
   gl_REPLACE_SYS_IOCTL_H
 fi
 gl_SYS_IOCTL_MODULE_INDICATOR([ioctl])
-gl_MODULE_INDICATOR([ioctl])
 
 Makefile.am:
 
--- modules/open.orig   Sun Mar 28 01:39:37 2010
+++ modules/open        Sun Mar 28 01:39:21 2010
@@ -12,7 +12,6 @@
 
 configure.ac:
 gl_FUNC_OPEN
-gl_MODULE_INDICATOR([open])
 gl_FCNTL_MODULE_INDICATOR([open])
 
 Makefile.am:
--- modules/stdlib-safer.orig   Sun Mar 28 01:39:37 2010
+++ modules/stdlib-safer        Sun Mar 28 01:39:21 2010
@@ -15,7 +15,6 @@
 
 configure.ac:
 gl_STDLIB_SAFER
-gl_MODULE_INDICATOR([stdlib-safer])
 
 Makefile.am:
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]