bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: timegm on mingw


From: Jim Meyering
Subject: Re: timegm on mingw
Date: Sat, 03 Apr 2010 21:58:46 +0200

Bruno Haible wrote:
> A similar error for timegm, in the C++ tests on mingw:
>
>   ../gllib/time.h:448: error: `timegm' was not declared in this scope
>
> Again, we need to distinguish the case of a missing function from the
> case of a broken function.
>
> m4/time_h.m4 contains some dubious code: If timegm exists and mktime
> works fine, but timegm is not declared, it sets REPLACE_TIMEGM to 1,
> and checks for the prerequisites of lib/timegm.c, but without doing a
> AC_LIBOBJ([timegm]). This makes no sense to me. Since we don't know
> of any platform that has timegm but does not declare it, I'm
> removing this code.
>
>
> 2010-04-03  Bruno Haible  <address@hidden>
>
>       timegm: Assume declaration if function exists.
>       * m4/timegm.m4 (gl_FUNC_TIMEGM): Assume timegm is declared if and only
>       if it exists. Don't clobber ac_cv_func_timegm.

That sounds sensible and the patch looks fine.
Thanks!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]