Re: [PATCH 00/15] Add libunistring-optional module

[Paolo Bonzini]

> Thanks for doing that! It is simpler than the solution that I had imagined
> for the use in gettext, and requires nearly no additional change for the
> user: He adds 'gl_LIBUNISTRING' to his configure.ac and is done with it.

Not even that if the modules do that for him.

> However, I disagree with some of your patches.
>
>
> 1) In part 04:
>
> >    AC_CONFIG_LINKS(gl_GNULIB_SOURCE_BASE[/$1.h]:gl_GNULIB_SOURCE_BASE[/$1.in.h])
>
> This line does two things wrong:
>
>    - It uses AC_CONFIG_LINKS.

Ok.

>        - It cannot work with multiple invocations of gnulib-tool in the
>          realm of the same configure.ac files.

True, I didn't know about this.

> 2) Part 01.
>
> It attempts to encapsulate the values of gnulib-tool parameters in autoconf
> macros. It cannot work, because they may be multiple gnulib-tool invocations
> in the scope of a single configure.ac.
>
> Drop this part.

Yes, not needed anymore.

> 5) In part 03 and part 04:
>
> What's the rationale for changing the not-found message from
> "no, consider installing GNU libunistring" to "no"? If the developer
> has determined that his programs would benefits from an installed,
> shared libunistring.so, then the message "no, consider installing
> GNU libunistring" is still appropriate, even if the dependency is an
> optional one.

Ok.  I think I can drop those altogether then.

> 6) Part 05..15:
>
> Should create the .h files in a Makefile.in section. Here's a template:

Thanks for suggesting how.

Don't hold your breath but I'll get round to doing this again sometime 
this week.

>    - Part 06, modules/unicase/locale-language: Why replace
>      lib/unicase/locale-languages.gperf with
>      lib/unicase/locale-languages.gperf.c?? That file does not exist.
>    - Part 08, modules/unictype/category-Cs: Why replace
>      lib/unictype/categ_Cs.c with lib/unictype/categ_Cs?? That file does not
>      exist.

Doh.  I screwed up the sedery.

Paolo