bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnulib bugs on OSX & C++


From: Jim Meyering
Subject: Re: gnulib bugs on OSX & C++
Date: Mon, 12 Apr 2010 06:17:14 +0200

Bruno Haible wrote:
>> The only formatting problem I saw was the one fixed here.
>> Did you mean something else?
>
> I also meant to move the REPLACE_FCHOWNAT=1 statement to the next line.
> It is too easily overlooked when it is tucked so far to the right.

I pushed this:

>From d6116655f30bb175a5c07707babc71a187b829ee Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sun, 11 Apr 2010 20:35:32 +0200
Subject: [PATCH] openat: correct formatting (no semantic change)

* m4/openat.m4 (gl_FUNC_FCHOWNAT): Correct formatting in AC_DEFINE.
Suggested by Bruno Haible.
---
 ChangeLog    |    6 ++++++
 m4/openat.m4 |   10 ++++++----
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index e156894..8dc4d2c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-04-11  Jim Meyering  <address@hidden>
+
+       openat: correct formatting (no semantic change)
+       * m4/openat.m4 (gl_FUNC_FCHOWNAT): Correct formatting in AC_DEFINE.
+       Suggested by Bruno Haible.
+
 2010-04-11  Bruno Haible  <address@hidden>

        Stricter declaration checking in testdirs.
diff --git a/m4/openat.m4 b/m4/openat.m4
index cfde8f9..80df704 100644
--- a/m4/openat.m4
+++ b/m4/openat.m4
@@ -1,4 +1,4 @@
-# serial 28
+# serial 29
 # See if we need to use our replacement for Solaris' openat et al functions.

 dnl Copyright (C) 2004-2010 Free Software Foundation, Inc.
@@ -104,9 +104,11 @@ AC_DEFUN([gl_FUNC_FCHOWNAT],
 [
   AC_REQUIRE([gl_FUNC_CHOWN])
   AC_CHECK_FUNC([fchownat],
-    [gl_FUNC_FCHOWNAT_DEREF_BUG([REPLACE_FCHOWNAT=1
-      AC_DEFINE([FCHOWNAT_NOFOLLOW_BUG], [1], [Define to 1 if your
-      platform has fchownat, but it cannot perform lchown tasks.])
+    [gl_FUNC_FCHOWNAT_DEREF_BUG([
+      REPLACE_FCHOWNAT=1
+      AC_DEFINE([FCHOWNAT_NOFOLLOW_BUG], [1],
+                [Define to 1 if your platform has fchownat, but it cannot
+                 perform lchown tasks.])
       if test $REPLACE_CHOWN = 1; then
         REPLACE_FCHOWNAT=1
       fi])],
--
1.7.1.rc1.237.ge1730




reply via email to

[Prev in Thread] Current Thread [Next in Thread]