[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] Avoid an 'empty declaration' / 'extraneous semicolon' wa
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 1/4] Avoid an 'empty declaration' / 'extraneous semicolon' warning |
|
Date: |
Tue, 27 Apr 2010 15:38:47 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b1 Thunderbird/3.0.4 |
On 04/27/2010 03:23 PM, Andreas Gruenbacher wrote:
> * lib/canonicalize-lgpl.c: Avoid an 'empty declaration' / 'extraneous
> semicolon' warning with some compilers.
>
Do you have commit rights to gnulib yet?
> diff --git a/lib/canonicalize-lgpl.c b/lib/canonicalize-lgpl.c
> index 480a132..d98b3ac 100644
> --- a/lib/canonicalize-lgpl.c
> +++ b/lib/canonicalize-lgpl.c
> @@ -334,7 +334,9 @@ error:
> }
> return NULL;
> }
> +#ifdef _LIBC
> versioned_symbol (libc, __realpath, realpath, GLIBC_2_3);
> +#endif
> #endif /* !FUNC_REALPATH_WORKS || defined _LIBC */
I would have used indentation:
# ifdef _LIBC
versioned_symbol...;
# endif
#endif /* comment */
But other than that, the patch looks fine.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature