bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/4] Use AM_MISSING_PROG when making bison the default YACC h


From: Jim Meyering
Subject: Re: [PATCH 4/4] Use AM_MISSING_PROG when making bison the default YACC here
Date: Wed, 28 Apr 2010 18:16:59 +0200

Bruno Haible wrote:
> Here's a proposed patch. It takes care to
>   - create getdate.c in the source directory,
>   - put into getdate.c #line statements that refer to "getdate.c", i.e.
>     don't depend on $(srcdir),
>   - use all Makefile variables that the automake generated .y.c rule would
>     use,
>   - interoperate with the automake flag 'silent-rules',
>   - not move a file onto itself.
>
> Jim, is that ok to commit?
>
>
> 2010-04-28  Bruno Haible  <address@hidden>
>
>       getdate: Generate getdate.c in the source directory.
>       * modules/getdate (Makefile.am): Add rule for getdate.c. Augment
>       MOSTLYCLEANFILES.
>       Suggested by Daniel Richard G. <address@hidden> and Ralf Wildenhues.

Thanks, Bruno.
That change looks fine, and passed some basic tests.
I noticed that it provides the additional benefit
of making the generated getdate.c file read-only.

You're welcome to push that.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]