Re: [PATCH] maint.mk: gnulib doesn't guarantee NSIG

[Jim Meyering]

Eric Blake wrote:
> Gnulib conditionally defines NSIG to 32 for some platforms.  But since
> NSIG is not mandated by standards, and there are platforms with 64
> signals, we should not promise that NSIG is guaranteed.
>
> * top/maint.mk (gl_extract_significant_defines_): Exclude NSIG.
...
>  gl_extract_significant_defines_ = \
> -  /^\# *define ([^_ (][^ (]*)(\s*\(|\s+\w+)/ && $$2 !~ 
> /(?:rpl_|_used_without_)/\
> +  /^\# *define ([^_ (][^ (]*)(\s*\(|\s+\w+)/\
> +    && $$2 !~ /(?:rpl_|_used_without_)/\
> +    && $$1 !~ /^(NSIG|ATTRIBUTE_NORETURN)/\
>      and print $$1

Thanks.
Here's a small follow-on patch:

>From 122c719820728d0f995ccbcafd8cf912b29e7df5 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Tue, 11 May 2010 18:49:29 +0200
Subject: [PATCH] maint.mk: tweak preceding change

* top/maint.mk (gl_extract_significant_defines_): Make exclusion
regexps tighter by anchoring at EOL, and make the new group "shy"
for slightly decreased overhead.
---
 ChangeLog    |    7 +++++++
 top/maint.mk |    2 +-
 2 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 9af2059..db77eb3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2010-05-11  Jim Meyering  <address@hidden>
+
+       maint.mk: tweak preceding change
+       * top/maint.mk (gl_extract_significant_defines_): Make exclusion
+       regexps tighter by anchoring at EOL, and make the new group "shy"
+       for slightly decreased overhead.
+
 2010-05-11  Eric Blake  <address@hidden>

        maint.mk: gnulib doesn't guarantee NSIG
diff --git a/top/maint.mk b/top/maint.mk
index 54fcbe9..3bcab0c 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -676,7 +676,7 @@ gl_other_headers_ ?= \
 gl_extract_significant_defines_ = \
   /^\# *define ([^_ (][^ (]*)(\s*\(|\s+\w+)/\
     && $$2 !~ /(?:rpl_|_used_without_)/\
-    && $$1 !~ /^(NSIG|ATTRIBUTE_NORETURN)/\
+    && $$1 !~ /^(?:NSIG|ATTRIBUTE_NORETURN)$$/\
     and print $$1

 # Create a list of regular expressions matching the names
--
1.7.1.189.g07419