bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 00/15] Add libunistring-optional module


From: Paolo Bonzini
Subject: Re: [PATCH 00/15] Add libunistring-optional module
Date: Wed, 19 May 2010 08:59:21 +0200

> Here's what I'm committing, based on your original patches. This shows only
> the non-repetitive part of the commit. For the entire commit, please look
> in git.

Nice.  Thanks for following up.

Two comments:

1) Is it so bad to drop the complicated code for 0.9-0.9.3 version
detection, and just assume 0.9 if the hexversion is 9?

2) What's the purpose of gl_LIBUNISTRING_VERSION_CMP_ORIG?  Why not add an

AS_LITERAL_IF([$1], , [m4_fatal([Argument of ]dnl
[[gl_LIBUNISTRING_VERSION_CMP] must be a literal])])

and drop the macro for the non-literal case?

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]