Re: gnulib tests leftovers

[Jim Meyering]

Ralf Wildenhues wrote:

> * Jim Meyering wrote on Sun, May 23, 2010 at 10:22:03AM CEST:
>> Looking at fixing that, I found that pwrite-tests already lists init.sh.
>> Hmm.  But it does not use it.
>>
>> Then I saw commit d8fa18472a54c1cb2674c296b3d82443f234d5f7,
>> which did this:
>>
>>      Remove useless test-pwrite.sh file.
>>      * tests/test-pwrite.sh: Delete file.
>>      * modules/pwrite-tests: Remove references.
>>      Reported by Bruno Haible.
>>
>> Obviously that use of init.sh wasn't so useless after all.
>> I'll do something to revert that change, while thinking about
>> how to automate wrapping such tests in general.
>
> Our mails crossed on this.  Of course I'm fine with whatever strategy
> ends up being used here.  I'll merely note that there are more tests
> which don't currently use init.sh, but use a similar naming and removal
> strategy (I looked at tests/test-areadlink.h when writing the patch).

They haven't been converted to use init.sh.
Considering the number of tests, converting would be a big and tedious job.

Not having to worry about cleaning up temporary files
and not having to choose "parallel-safe" names for them
leads to much cleaner tests.
Not having to add signal handlers in every single one
avoids duplication and would make them robust by default.

IMHO, all new tests should use init.sh, but we haven't
discussed whether this should be policy.