bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: btw, gl_SNPRINTF_RETVAL_C99 was expanded before it was required...


From: Bruno Haible
Subject: Re: btw, gl_SNPRINTF_RETVAL_C99 was expanded before it was required...
Date: Fri, 11 Jun 2010 01:12:36 +0200
User-agent: KMail/1.9.9

Hi Jim,

> When running the new test,
> 
>      ./gnulib-tool --create-testdir --with-tests --test inttostr
> 
> I saw lots of warnings like this go by:
> 
>     configure.ac:170: warning: AC_REQUIRE: `gl_SNPRINTF_RETVAL_C99' was 
> expanded before it was required
>     glm4/vasnprintf.m4:15: gl_REPLACE_VASNPRINTF is expanded from...
>     glm4/snprintf-posix.m4:7: gl_FUNC_SNPRINTF_POSIX is expanded from...
>     configure.ac:29: gl_INIT is expanded from...
>     configure.ac:170: the top level
>     executing autoconf
>     configure.ac:170: warning: AC_REQUIRE: `gl_SNPRINTF_RETVAL_C99' was 
> expanded before it was required
>     glm4/vasnprintf.m4:15: gl_REPLACE_VASNPRINTF is expanded from...
>     glm4/snprintf-posix.m4:7: gl_FUNC_SNPRINTF_POSIX is expanded from...

Indeed, I reproduce (with gnulib just before your latest change to
inttostr-tests).

Your patch is right (converting all uses of this macro to AC_REQUIRE
or all uses to invocations would not be ideal), and it is complete
(the problem does not occur with any other macros from printf.m4). So,
please commit it.

Thanks!

Bruno



reply via email to

[Prev in Thread] Current Thread [Next in Thread]