bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] test-xvasprintf: avoid 'const' discard warnings


From: Jim Meyering
Subject: [PATCH] test-xvasprintf: avoid 'const' discard warnings
Date: Fri, 11 Jun 2010 11:13:37 +0200

I've just pushed this, too:

>From 9e1e9d8f3bac7fb52b026f0b628eb37d3a839097 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Fri, 11 Jun 2010 11:03:54 +0200
Subject: [PATCH] test-xvasprintf: avoid 'const' discard warnings

* tests/test-xvasprintf.c (test_xvasprintf, test_xasprintf): Use
"const" when assigning from literal strings.
(test_xasprintf): Add "void" in function argument list to placate
-Wstrict-prototypes and to be consistent with test_xvasprintf above.
---
 ChangeLog               |    6 ++++++
 tests/test-xvasprintf.c |    6 +++---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index d96f7fe..456a793 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2010-06-11  Jim Meyering  <address@hidden>

+       test-xvasprintf: avoid 'const' discard warnings
+       * tests/test-xvasprintf.c (test_xvasprintf, test_xasprintf): Use
+       "const" when assigning from literal strings.
+       (test_xasprintf): Add "void" in function argument list to placate
+       -Wstrict-prototypes and to be consistent with test_xvasprintf above.
+
        tests: avoid compilation warnings in argmatch and exclude tests...
        in packages that define ARGMATCH_DIE_DECL, like coreutils.
        * tests/test-exclude.c [ARGMATCH_DIE_DECL]: Also declare the function.
diff --git a/tests/test-xvasprintf.c b/tests/test-xvasprintf.c
index df6c200..023067a 100644
--- a/tests/test-xvasprintf.c
+++ b/tests/test-xvasprintf.c
@@ -55,7 +55,7 @@ test_xvasprintf (void)

   {
     /* Silence gcc warning about zero-length format string.  */
-    char *empty = "";
+    const char *empty = "";
     result = my_xasprintf (empty);
     ASSERT (result != NULL);
     ASSERT (strcmp (result, "") == 0);
@@ -79,7 +79,7 @@ test_xvasprintf (void)
 }

 static void
-test_xasprintf ()
+test_xasprintf (void)
 {
   int repeat;
   char *result;
@@ -94,7 +94,7 @@ test_xasprintf ()

   {
     /* Silence gcc warning about zero-length format string.  */
-    char *empty = "";
+    const char *empty = "";
     result = xasprintf (empty);
     ASSERT (result != NULL);
     ASSERT (strcmp (result, "") == 0);
--
1.7.1.501.g23b46



reply via email to

[Prev in Thread] Current Thread [Next in Thread]