bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] bootstrap: discard non translation project po files


From: Pádraig Brady
Subject: Re: [PATCH] bootstrap: discard non translation project po files
Date: Tue, 06 Jul 2010 22:18:04 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3

On 06/07/10 20:12, Ralf Wildenhues wrote:
> Hi Pádraig,
> 
> * Pádraig Brady wrote on Tue, Jul 06, 2010 at 11:02:06AM CEST:
>> >From 3c537222dd86cdd62f21e085f0a8c43d6fc9707c Mon Sep 17 00:00:00 2001
>> From: =?utf-8?q?P=C3=A1draig=20Brady?= <address@hidden>
>> Date: Tue, 6 Jul 2010 10:00:05 +0100
>> Subject: [PATCH] bootstrap: discard non translation project po files
>>
>> * build-aux/bootstrap (update_po_files): Remove any
>> local only files from the $po_dir/.reference directory.
>> The LINGUAS index is generated from this directory
>> and so those translations will not be distributed.
>> Note, local only translations are not removed from the
>> $po_dir directory.
> 
>> --- a/build-aux/bootstrap
>> +++ b/build-aux/bootstrap
>> @@ -90,7 +90,8 @@ bootstrap_epilogue() { :; }
>>  # options because the latest/%s directory and the .po files within are
>>  # all symlinks.
>>  po_download_command_format=\
>> -"rsync -Lrtvz 'translationproject.org::tp/latest/%s/' '%s'"
>> +"rsync --delete --exclude '*.s1' -Lrtvz \
>> + 'translationproject.org::tp/latest/%s/' '%s'"
> 
> Won't this remove unrelated files from the directory, too?
> IOW, if I happen to be writing a new translation, but it is
> not official yet, an innocent bootstrap will kill those long
> hours of work for me?  That would be very scary.

I considered also specifying --backup but didn't
since as mentioned in the log "local only translations
are not removed from the $po_dir". Is that sufficient backup?

I just noticed that I need to manually update $scriptversion.
Updated patch follows.

cheers,
Pádraig.

>From 2379658015b6b2c460ab353c1a4f635913b34f20 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?P=C3=A1draig=20Brady?= <address@hidden>
Date: Tue, 6 Jul 2010 10:00:05 +0100
Subject: [PATCH] bootstrap: discard non translation project po files

* build-aux/bootstrap (update_po_files): Remove any
local only files from the $po_dir/.reference directory.
The LINGUAS index is generated from this directory
and so those translations will not be distributed.
Note, local only translations are not removed from the
$po_dir directory.
---
 build-aux/bootstrap |   11 +++++++----
 1 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/build-aux/bootstrap b/build-aux/bootstrap
index 2422549..5ab4cf7 100755
--- a/build-aux/bootstrap
+++ b/build-aux/bootstrap
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Print a version string.
-scriptversion=2010-05-17.18; # UTC
+scriptversion=2010-07-06.10; # UTC

 # Bootstrap this package from checked-out sources.

@@ -90,7 +90,8 @@ bootstrap_epilogue() { :; }
 # options because the latest/%s directory and the .po files within are
 # all symlinks.
 po_download_command_format=\
-"rsync -Lrtvz 'translationproject.org::tp/latest/%s/' '%s'"
+"rsync --delete --exclude '*.s1' -Lrtvz \
+ 'translationproject.org::tp/latest/%s/' '%s'"

 extract_package_name='
   /^AC_INIT(/{
@@ -475,15 +476,17 @@ download_po_files() {
   eval "$cmd"
 }

-# Download .po files to $po_dir/.reference and copy only the new
+# Mirror .po files to $po_dir/.reference and copy only the new
 # or modified ones into $po_dir.  Also update $po_dir/LINGUAS.
+# Note po files that exist locally only are left in $po_dir but will
+# not be included in LINGUAS and hence will not be distributed.
 update_po_files() {
   # Directory containing primary .po files.
   # Overwrite them only when we're sure a .po file is new.
   po_dir=$1
   domain=$2

-  # Download *.po files into this dir.
+  # Mirror *.po files into this dir.
   # Usually contains *.s1 checksum files.
   ref_po_dir="$po_dir/.reference"

-- 
1.6.2.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]