Re: [PATCH v2 0/5] Speed up uNN_chr and uNN_strchr with Boyer-Moore algorithm

[Paolo Bonzini]

On 07/27/2010 06:06 PM, Pádraig Brady wrote:
> On 23/07/10 13:03, Paolo Bonzini wrote:
> > On 07/23/2010 09:21 AM, Bruno Haible wrote:
> > > Otherwise fine, please commit. I can add comments that prove the
> > > validity of
> > > the code later, after you committed it.
> >
> > v2 already had large comments that detail the algorithm used and do
> > include all the info in the comments you suggested.  Feel free to add
> > more to it.
> >
> > I pushed it now, thanks for the review!
>
> I would suggest a new function due to the
> way I see this function called most often.
> I.E. repeatedly with the same character.

Is this really a bottleneck?  i.e., what does u8_uctomb_aux look like in 
the profile when do a million u8_strchr calls on an empty string?

Paolo