bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: strtod [was: M4 1.4.14 on AIX 7.1BETA]


From: Eric Blake
Subject: Re: strtod [was: M4 1.4.14 on AIX 7.1BETA]
Date: Thu, 29 Jul 2010 09:58:25 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.1.1

[let's keep the list in the loop]

On 07/29/2010 09:47 AM, Rainer Tammer wrote:
>  Hello,
> 
> On 29.07.2010 17:26, Eric Blake wrote:
>> On 07/29/2010 09:26 AM, Rainer Tammer wrote:
>>>  Hello Eric,
>>> FYI, config.guess is on git (this was really fast).
>> Indeed - but it hasn't percolated to gnulib yet, which means the m4
>> 1.4.14.6 snapshot that I built doesn't include it.  m4 1.4.15 will have
>> it, though.
>>
> 
> source: m4-1.4.14.6-ffa0
> 
> 1. The test-strtod is still failing
> 
> # ./test-strtod (compiled and executet manually)
> test-strtod.c:389: assertion failed

With the system's strtod, or with gnulib's replacement?  I'm wondering
if you may have missed some prerequisites in the process.

How about running:

cd tests && make -k check

(if you have GNU make, you could use 'make -k -C tests check')

so that we can see all of the gnulib unit test results.

> 2. make check... that's another story.
> The 1.14.14 had only the failing stdtod test.

> 
> # tail -f check.log
> Checking ./164.regexp
> @ ../doc/m4.texinfo:5688: Origin of test
> ./164.regexp: stdout mismatch
> --- m4-tmp.8716458/m4-xout      2010-07-29 17:34:17.000000000 +0200
> +++ m4-tmp.8716458/m4-out       2010-07-29 17:34:17.000000000 +0200
> @@ -1,4 +1,4 @@
> - 5
> - -1
> +
> +
>   *** Unix *** nix ***
> 
> @ ../doc/m4.texinfo:5688: Origin of test
> ./164.regexp: stderr mismatch
> --- m4-tmp.8716458/m4-xerr      2010-07-29 17:34:17.000000000 +0200
> +++ m4-tmp.8716458/m4-err       2010-07-29 17:34:17.000000000 +0200
> @@ -0 +1,3 @@
> + m4:stdin:1: bad regular expression: `\<[a-z]\w+': Memory exhausted
> + m4:stdin:2: bad regular expression: `\<Q\w*': Memory exhausted
> + m4:stdin:4: bad regular expression: `\<Q\w*': Memory exhausted

That's more than just the strtod test failing, and not the sort of thing
I like to see.  The gnulib regex code has been updated in the meantime;
wonder if this introduced the problem.

> @@ -1 +1,3 @@
> + m4:stdin:1: bad regular expression `^': Memory exhausted
> + m4:stdin:2: bad regular expression `\<': Memory exhausted

Even simpler examples that shouldn't cause ENOMEM.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]