bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Question about some fields in regex's re_pattern_buffer


From: Reuben Thomas
Subject: Re: Question about some fields in regex's re_pattern_buffer
Date: Sat, 14 Aug 2010 17:04:09 +0100

On 3 August 2010 23:21, Bruno Haible <address@hidden> wrote:
> Feel free to submit a patch that Eric or Karl or I can apply.

In the end I found very little to change on a first look. The attached patch:

1. Removes mentions of regex.c.

2. Adds documentation of not_eol.

The other questions which I asked are mostly addressed.

re_set_registers is not documented; there's a note about this. I'd be
happy to write some documentation for that. There's also the technique
of re-using a registers data structure by NOT re_compile_fastmap, but
using the fastmap member of the struct directly. Finally, there's the
problem of the non-thread-safety of RE_NO_SUB which Paolo mentioned;
again, I can document that if we're not going to solve it immediately.

-- 
http://rrt.sc3d.org

Attachment: 0001-Document-not_eol-and-remove-mention-of-regex.c.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]