bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Question about some fields in regex's re_pattern_buffer


From: Bruno Haible
Subject: Re: Question about some fields in regex's re_pattern_buffer
Date: Sat, 14 Aug 2010 20:48:30 +0200
User-agent: KMail/1.9.9

Reuben Thomas wrote:
> In the end I found very little to change on a first look. The attached patch:
> 
> 1. Removes mentions of regex.c.

I've committed this part for you.

> 2. Adds documentation of not_eol.

I haven't committed this part, because you added a paragraph about not_eol
in the section Match-beginning-of-line Operator, where in my opinion it
belongs in section Match-end-of-line Operator.

> re_set_registers is not documented; there's a note about this. I'd be
> happy to write some documentation for that. There's also the technique
> of re-using a registers data structure by NOT re_compile_fastmap, but
> using the fastmap member of the struct directly. Finally, there's the
> problem of the non-thread-safety of RE_NO_SUB which Paolo mentioned;
> again, I can document that if we're not going to solve it immediately.

I can't comment on this. Paolo?

Bruno



reply via email to

[Prev in Thread] Current Thread [Next in Thread]