bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Fix malloc, calloc, realloc (was: debugging M4 on AIX 5.3)


From: Ralf Wildenhues
Subject: Fix malloc, calloc, realloc (was: debugging M4 on AIX 5.3)
Date: Sat, 28 Aug 2010 09:40:34 +0200
User-agent: Mutt/1.5.20 (2010-04-22)

* Ralf Wildenhues wrote on Wed, Aug 25, 2010 at 11:25:03PM CEST:
> Continuing with M4 branch-1.4 failures on AIX 5.3:
[...]
> *** m4-tmp.569356/m4-xerr       Wed Aug 25 19:05:46 2010
> --- m4-tmp.569356/m4-err        Wed Aug 25 19:05:46 2010
> ***************
> *** 0 ****
> --- 1,3 ----
> + m4:stdin:1: bad regular expression: `\<[a-z]\w+': Memory exhausted

> Bisect showed that if I go back to v1.4.14, the errors persist.
> 
> Bisect of gnulib/ subdir converges at
> commit 723fc0b7b3a5d770a48945c1e1bca262a4c2615a
> which is the "Use modern idiom for malloc() replacement." patch in
> http://lists.gnu.org/archive/html/bug-gnulib/2010-06/msg00176.html
> (all errors stem from this patch).
> 
> I see that confdefs.h before contains '#define malloc rpl_malloc'
> and doesn't afterwards, but no other changes in the output section
> of the respective config.log files.  Assuming that the stdlib.h header
> logic is correct, my next best bet would be that some source doesn't
> actually get to see the replaced header, but can't find any instances
> of that right now, and it's late ...

malloc is broken, as is calloc.  Inspection indicates realloc too.

Bruno, I suggest this patch series to fix the fallout from:
http://lists.gnu.org/archive/html/bug-gnulib/2010-06/msg00176.html

I have confirmed that the tests expose the breakage of malloc and calloc
on AIX, and the final patch fixes them.  OK to commit?

The patch series makes M4's own testsuite pass, but in the meantime,
something else broke again so I'm still not completely done.

Thanks,
Ralf

Attachment: 0001-Tests-for-module-calloc.patch
Description: Text document

Attachment: 0002-Tests-for-module-malloc.patch
Description: Text document

Attachment: 0003-Tests-for-module-realloc.patch
Description: Text document

Attachment: 0004-Fix-malloc-calloc-and-realloc-modules-for-AIX.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]