bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: failure to build due to ignoring fwrite() result


From: Paolo Bonzini
Subject: Re: failure to build due to ignoring fwrite() result
Date: Tue, 31 Aug 2010 10:51:45 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5

On 08/31/2010 03:24 AM, Bruno Haible wrote:
Hi Paul,

+ @pindex gcc
   @pindex lint
! @pindex valgrind
! Don't make the program ugly to placate @code{gcc -Wall},

-Wextra should fix Bruno's valid complaint.

@code{lint},
! @code{valgrind}, or other software analysis tools.  These tools can
! help find bugs, but they can also generate false alarms for constructs
! that they incorrectly consider to be suspicious.  Although we want
! useful warnings and don't want useless ones, we also want code that is
! as readable as possible and is not cluttered with unnecessary casts or
! wrappers.  For example, in C, please don't insert casts to @code{void}
! or replace @code{0} with @code{NULL} merely to pacify a lint checker.
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I agree this should be removed, and possibly replaced with a better example.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]