bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fdutimensat: add an atflag parameter


From: Paul Eggert
Subject: Re: [PATCH] fdutimensat: add an atflag parameter
Date: Fri, 17 Sep 2010 11:14:37 -0700
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100915 Thunderbird/3.0.8

Thanks for adding that functionality to gnulib.  I prepared a patch
to have GNU tar use it, but found one more problem.  fdutimensat
uses this signature:

fdutimensat (int dir, char const *file, int fd, [ other args ] )

whereas the similar function in GNU tar uses the following
order instead.

fdutimensat (int fd, int dir, char const *file, [ other args ] )

The GNU tar convention is clearer, since it reflects the
semantics better: try FD first, and use that if it works;
otherwise fall back on DIR+FILE.  Could we please switch to
this order, while we're changing the API anyway?  I'll do
the gnulib gruntwork if that helps.  (And I apologize for
not earlier noticing this lack of conformance to Leibniz's
principles of notation design. :-)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]