[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [libvirt] [PATCH] autogen: allow aclocal to receive arguments via an
From: |
Jim Meyering |
Subject: |
Re: [libvirt] [PATCH] autogen: allow aclocal to receive arguments via an environment variable |
Date: |
Thu, 30 Sep 2010 23:04:59 +0200 |
Eric Blake wrote:
> [moving to bug-gnulib]
> On 09/19/2010 01:21 AM, Justin Clift wrote:
...
>> The next step is to get all required pieces from gnulib,
>> to run autoreconf, and to invoke ./configure:
>>
>> diff --git a/bootstrap b/bootstrap
>> index 2422549..593e0b2 100755
>> --- a/bootstrap
>> +++ b/bootstrap
>> @@ -775,7 +775,7 @@ grep -E '^[ ]*AC_CONFIG_HEADERS?\>'
>> configure.ac>/dev/null ||
>>
>> for command in \
>> libtool \
>> - "${ACLOCAL-aclocal} --force -I m4" \
>> + "${ACLOCAL-aclocal} --force -I m4 ${ACLOCAL_FLAGS}" \
>
> At first glance, this actually looks reasonable to me. Anyone else
> have any comments or ideas for a better approach?
Looks fine to me, but please drop the curly braces
from the new variable reference.