bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] renameat: port to Solaris 10, which declares renameat in uni


From: Eric Blake
Subject: Re: [PATCH] renameat: port to Solaris 10, which declares renameat in unistd.h
Date: Tue, 26 Oct 2010 15:36:59 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.4

On 10/26/2010 02:51 PM, Paul Eggert wrote:
* lib/renameat.c: Include unistd.h before stdio.h, because
Solaris 10 declares renameat in unistd.h.  Problem encountered
when building GNU tar 1.24 on Solaris 10.
---
  ChangeLog      |    8 ++++++++
  lib/renameat.c |    6 ++++++
  2 files changed, 14 insertions(+), 0 deletions(-)

Shouldn't the real fix to be fixing our <stdio.h> replacement to pull in <unistd.h> prior to re-declaring renameat? That is, our goal is that all files except for .m4 probes and our replacement headers should be immune to header reordering issues.

I'll come up with a better patch.

--
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]