bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] ceil, floor, round, trunc: enhance tests of -0


From: Ben Pfaff
Subject: Re: [PATCH 2/2] ceil, floor, round, trunc: enhance tests of -0
Date: Thu, 04 Nov 2010 20:50:47 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

Eric Blake <address@hidden> writes:

> In my minus_zero cleanups, I noticed that these tests were rather
> weak; it's possible that there are implementations that return 0.0
> when they should be returning -0.0, so let's test that explicitly.
> The new checks should work even on systems that lack -0.0 (if there
> are any; I'm not convinced that SGI really lacks -0.0 on MIPS, so
> much as has a buggy compiler that doesn't expose it well, but I
> haven't recently logged on to an Irix machine to test this).

This looks good to me, for the "round" modules that I maintain.
-- 
Ben Pfaff 
http://benpfaff.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]