bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libposix stuff


From: Gary V. Vaughan
Subject: Re: libposix stuff
Date: Tue, 9 Nov 2010 00:12:22 +0700

Hi Bruce, Bruno,

On 8 Nov 2010, at 23:29, Bruce Korb wrote:
>>> $ ls -1 $(allbut usr/local/include/*.h - $(
>>>>>> egrep -l '#ifndef _LIBPOSIX_' usr/local/include/*.h) )
>>>> usr/local/include/arg-nonnull.h
>>>> usr/local/include/iconv_open-aix.h
>>>> usr/local/include/iconv_open-hpux.h
>>>> usr/local/include/iconv_open-irix.h
>>>> usr/local/include/iconv_open-osf.h
>>>> usr/local/include/iconv_open-solaris.h
>>>> usr/local/include/inttypes.h
>>>> usr/local/include/unitypes.h
>>>> usr/local/include/unused-parameter.h
>>>> usr/local/include/warn-on-use.h
>> The only file in this list that contains public API is inttypes.h.
>> The others should not be installed in a public location.
>> 
>> The 'Include:' section of the module descriptions tells you about
>> this. Files that are not mentioned in the 'Include:' section of
>> any module description are private.
> 
> This is all being driven off of a script.  Does this mean that this
> script is expected to parse the contents of the modules files?
> It would seem to me that when gnulib-tool constructs the makefile.am's,
> it should ensure its correctness and not require my script to parse
> modules files and re-edit its output.  What are you saying, please?

As I understand it, gnulib-tool itself will handle everything.

At least it is supposed to, as long as the nodist/nobase/noinst_include_HEADER 
declarations are set up correctly in the module files. Of course, only the 
public headers should be installed, and therefore only they should have their 
include guards substituted accordingly.

If that's not already the case, then there is a bug in the topic/libposix 
changeset 328513b3a6d6612984b1931ab27466e27014e022 (which adds the HEADER 
primaries to the module files), or perhaps even a bug in the Makefile.am 
sections of the affected module files (i.e. the ones that are causing private 
header files to be installed), which will require a fix on the topic/libposix 
branch prior to merging.

Cheers,
-- 
Gary V. Vaughan (address@hidden)

Attachment: PGP.sig
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]