bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: m4/mknod.m4: minor portability fix


From: Eric Blake
Subject: Re: m4/mknod.m4: minor portability fix
Date: Thu, 11 Nov 2010 11:10:17 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.6

On 11/09/2010 09:38 AM, Christian Weisgerber wrote:
> I noticed this in GNU tar 1.25 when FreeBSD's test(1) complained:
> 
> Use "=" operator for test(1), rather than non-standard "==".
> 
> 
> --- m4/mknod.m4.orig  Tue Nov  9 17:35:22 2010
> +++ m4/mknod.m4       Tue Nov  9 17:35:32 2010
> @@ -30,7 +30,7 @@
>        if (!geteuid ()) return 99;
>        if (mknod ("conftest.fifo", S_IFIFO | 0600, 0)) return 2;]])],
>           [gl_cv_func_mknod_works=yes],
> -         [if test $? == 99 && test x"$FORCE_UNSAFE_CONFIGURE" = x; then
> +         [if test $? = 99 && test x"$FORCE_UNSAFE_CONFIGURE" = x; then

Thanks; pushed.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]