bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch 1/3 for topic/libposix


From: Bruce Korb
Subject: Re: Patch 1/3 for topic/libposix
Date: Fri, 12 Nov 2010 07:39:34 -0800
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100914 SUSE/3.0.8 Thunderbird/3.0.8

On 11/11/10 18:58, Bruno Haible wrote:
> Bruce Korb wrote:
>> First patch changes the failing printf tests so that:
>> 1. ...
>> 2. the wrapper scripts detect "I failed on the first
>>    iteration" exit codes and causes the test to be
>>    bypassed with "exit 77" exit codes.
> 
> But that means that the test would be skipped in some circumstances,
> and we don't know whether fprintf has a memory leak or not. That is
> a mere cover-up action. I am opposed to this approach. If you have
> a test failure that is too hard to investigate or that no one has
> understood so far, let it continue to fail. At some point, someone
> will take care of it. Either by investigating it in a friendlier
> environment, or by marking it an "unportable-test" in the module
> description.

Then it is not necessary to polish libposix to the point where
this succeeds?

  set -e
  cd gnulib/libposix
  ./bootstrap
  ./configure
  make all check
  sudo make install

That's fine by me because libposix is an isolated thing that is
not invoked by default.  You have to go into that directory and
deliberately invoke the bootstrap, so it should do no harm being
in the main line.  I was operating on the assumption that this
should run to completion before putting it into "master".
Would you please clarify what is expected?  Thank you!

Regards, Bruce



reply via email to

[Prev in Thread] Current Thread [Next in Thread]