[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] maintainer-makefile: prohibit test x == x
From: |
Eric Blake |
Subject: |
[PATCH] maintainer-makefile: prohibit test x == x |
Date: |
Fri, 12 Nov 2010 14:12:07 -0700 |
* top/maint.mk (sc_prohibit_test_double_equal): New rule.
Based on a report by Matthias Bolte.
Signed-off-by: Eric Blake <address@hidden>
---
Caught some bugs in libvirt, so I'm pushing it.
ChangeLog | 4 ++++
top/maint.mk | 6 ++++++
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 8a9d7b6..21677e2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
2010-11-12 Eric Blake <address@hidden>
+ maintainer-makefile: prohibit test x == x
+ * top/maint.mk (sc_prohibit_test_double_equal): New rule.
+ Based on a report by Matthias Bolte.
+
bootstrap: allow FreeBSD gzip
* build-aux/bootstrap (get_version): Parse FreeBSD gzip version,
which has no '.' and goes to stderr.
diff --git a/top/maint.mk b/top/maint.mk
index 181a96f..d51944b 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -817,6 +817,12 @@ sc_prohibit_test_minus_ao:
halt='$(_ptm1); $(_ptm2)' \
$(_sc_search_regexp)
+# Avoid a test bashism.
+sc_prohibit_test_double_equal:
+ @prohibit='(\<test| \[+) .+ == ' \
+ halt='use "test x = x", not "test x =''= x"' \
+ $(_sc_search_regexp)
+
# Each program that uses proper_name_utf8 must link with one of the
# ICONV libraries. Otherwise, some ICONV library must appear in LDADD.
# The perl -0777 invocation below extracts the possibly-multi-line
--
1.7.3.2
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] maintainer-makefile: prohibit test x == x,
Eric Blake <=