|
| From: | Paolo Bonzini |
| Subject: | Re: [PATCH] maint.mk: tighten "test a == b" check |
| Date: | Sat, 13 Nov 2010 19:31:37 +0100 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101027 Fedora/3.1.6-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.6 |
On 11/13/2010 07:10 PM, Eric Blake wrote:
Maybe a compromise would be to revert this, but to tighten the prohibit
regex:
prohibit='(\<test| \[+) ("[^"]*"|[^ ]+) == '
which misses out on both false positives in coreutils, but still detects
the libvirt bug?
Or the shell syntax checks' $containing could be set with a makefile variable (defaulting to ^#! */bin/sh but overridable by libvirt).
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |