bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: rename, renameat test


From: Eric Blake
Subject: Re: rename, renameat test
Date: Sat, 13 Nov 2010 13:50:07 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.6

On 11/12/2010 04:48 PM, Bruno Haible wrote:
> Hi Eric,
> 
> On a RHEL 5 system I was seeing these test failures:
> 
>   test-rename.h:119: assertion failed
>   FAIL: test-rename
>   test-rename.h:119: assertion failed
>   FAIL: test-renameat
> 
> In the way the test case is currently written, I have to read from the top,
> 100 lines of assertions, to understand what the current situation on the
> file system is, what the previous func() invocation intended to do, and
> what may be the reason of the failure.
> 
> Reading 100 (or 400) lines of such code is tedious, I wouldn't want to do
> it once again, and therefore would like to ask for permission to add
> comments and structure to this test.

Go for it!

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]