Re: [PATCH] bootstrap: avoid broken Solaris sed

[Eric Blake]

On 11/13/2010 07:16 PM, Paul Eggert wrote:
> On 11/13/2010 03:18 PM, Eric Blake wrote:
>> +    if test -x /usr/xpg4/bin/sed; then
> 
> I'm leery about using XPG4 sed on Solaris.
> That has its own set of bugs, which in practice can
> bite just as often as the standard 'sed', maybe more
> often.  One classic example: it can't handle scripts
> containing more than 100 lines.  I'm sure there are
> others.
> 
> Instead, I suggest rewriting 'bootstrap' so that it
> works even with standard 'sed' on Solaris.  In this
> case it's pretty easy: the rewrite is shorter and
> arguably clearer than the original.

I like this alternative.  Certainly a smaller patch than my proposal for
guaranteeing a semi-decent sed, and still easy to follow what the sed
script is doing.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature