Re: [PATCH] argp: fix program_invocation_name detection

[Bruno Haible]

Mike Frysinger wrote:
> > > The current program_invocation_name symbol detection fails if the argp.h
> > > header is missing.
> > 
> > Your patch would make sense if there was a platform with an <errno.h> that
> > declares program_invocation_name, but without an <argp.h> file. Which
> > platform is this?
> 
> uClibc exhibits this behavior, but i dont see why the platform matters.  the 
> current behavior is clearly wrong.

The platform matters, because every commit needs a rationale. You could not say
that code that has been working fine for 8 years is "clearly wrong" if you
couldn't exhibit a situation where it fails to work, and this situation is
reproducible on more than one machine.

Since it's uClibc, your patch is fine. I'll apply it tomorrow, with a couple
of comments. Thanks.

Bruno