Re: getpass: get system declaration

[Jim Meyering]

Bruno Haible wrote:
> On Solaris at least, getpass() is not declared in <unistd.h> or <stdlib.h> if
> __EXTENSIONS__ is not defined. This fixes the autoconf test and the use of
> <unistd.h> in lib/getpass.h.
>
> By the way, on all systems (including glibc), getpass() is declared by
> including <unistd.h>. I would propose to move its declaration in gnulib
> from "getpass.h" to <unistd.h>, and to drop getpass.h. (getpass.h was
> created in 2004, when we didn't have a <unistd.h> replacement.)
> Objections?
>
> 2010-11-26  Bruno Haible  <address@hidden>
>
>       getpass: Make sure to get system declaration on some platforms.
>       * m4/getpass.m4 (gl_FUNC_GETPASS, gl_FUNC_GETPASS_GNU): Require
>       gl_USE_SYSTEM_EXTENSIONS.
>       * modules/getpass (Depends-on): Add extensions.

Sounds good to me.