[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: getdomainname: fix several problems
From: |
Paul Eggert |
Subject: |
Re: getdomainname: fix several problems |
Date: |
Sun, 28 Nov 2010 17:56:13 -0800 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 |
Thanks, that looks good, except for a couple of minor details:
> + int ret;
> +
> + if (len > INT_MAX)
> + len = INT_MAX;
> + ret = sysinfo (SI_SRPC_DOMAIN, name, len);
'ret' should be of type long int, not int, and
the INT_MAX should be LONG_MAX (twice).
> dnl Where is getdomainname() defined?
> - dnl - On Solaris, it is in libnsl.
> + dnl - On Solaris, it is in libnsl. But this function is not declared and
> + dnl is deprecated, see
It's private, not deprecated.
Re: getdomainname: fix several problems, Simon Josefsson, 2010/11/28