Re: unistr use of undefined macros

[Ludovic Courtès]

Hi Eric,

Eric Blake <address@hidden> writes:

> On 12/07/2010 02:24 PM, Ludovic Courtès wrote:
>> Hello,
>> 
>> Commit c98cb289 changed #ifdefs in unistr.in.h to #ifs.  As a
>> side-effect, this prevents compilation of users of this file, such as
>> Guile, with ‘-Wundef’:
>
> Unfortunately, that points to a bug in guile.
>
> Gnulib is explicitly documented as being incompatible with -Wundef; and
> while you may choose to use it for the rest of your project, you should
> not use it for gnulib files.

That’s what Guile is doing already.

The error here is when *using* <unistr.h> from libguile, which is
compiled with -Wundef.

> See for example how coreutils sets up two distinct CFLAGS, a stricter
> one for coreutils files in src/ [1] and a looser one for gnulib files in
> lib/ [2]:

I just changed <http://hydra.nixos.org/jobset/gnu/coreutils-master/> so
that Coreutils is built with ‘--enable-gcc-warnings’, and it builds
fine.

However:

--8<---------------cut here---------------start------------->8---
$ grep -r 'unistr.[ch]' . ; echo $?
1
--8<---------------cut here---------------end--------------->8---

(This is in a pristine checkout, without Gnulib in here.)

So no wonder it doesn’t hit that problem.

Thanks,
Ludo’.