Re: Possible Bug in Gnulib

[Bruno Haible]

Hello Noah,

> I configured Guile with
> 
> ./configure --prefix=/Users/noah/Desktop/guile
> --with-libiconv-prefix=/opt/local
> --with-libunistring-prefix=/opt/local --with-libgmp-prefix=/opt/local
> --with-libintl-prefix=/opt/local --with-libreadline-prefix=/opt/local
> --enable-guile-debug.

This is all fine.

> REPLACE_ICONV_UTF is defined as 1. Here
> is what I found in config.log.
> 
> First, there is an expected failure of an iconv test, where configure
> didn't use the iconv path I gave it. It then reran the test with the
> correct iconv path and found that iconv worked.
> 
> The test that prints "checking for working iconv" also returned yes.
> 
> However, the test "checking whether iconv supports conversion between
> UTF-8 and UTF-{16,32}{BE,LE}" failed, on the conversion from UTF-8 to
> UTF-32LE.

Bingo! I get a failure also on glibc systems. It's due to a typo that
I unfortunately made on 2010-12-04.

Thank you very much for investigating and pointing to the precise spot
where the problem was.


2010-12-19  Bruno Haible  <address@hidden>

        iconv_open: Fix regression from 2010-12-04.
        * m4/iconv_open.m4 (gl_FUNC_ICONV_OPEN_UTF): Fix typo.
        Reported by Noah Lavine <address@hidden>.

--- m4/iconv_open.m4.orig       Mon Dec 20 00:16:33 2010
+++ m4/iconv_open.m4    Mon Dec 20 00:15:46 2010
@@ -1,4 +1,4 @@
-# iconv_open.m4 serial 11
+# iconv_open.m4 serial 12
 dnl Copyright (C) 2007-2010 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -203,7 +203,7 @@
           result |= 8;
         else if (!(memcmp (buf, expected, sizeof (expected) - 1) == 0))
           result |= 8;
-        else if ((iconv_close (cd) == 0))
+        else if (!(iconv_close (cd) == 0))
           result |= 8;
       }
   }